lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 3 Sep 2010 23:11:35 +0900 From: "Masayuki Ohtake" <masa-korg@....okisemi.com> To: "Eric Dumazet" <eric.dumazet@...il.com> Cc: "Stephen Hemminger" <shemminger@...tta.com>, "Sam Ravnborg" <sam@...nborg.org>, "Joe Perches" <joe@...ches.com>, "LKML" <linux-kernel@...r.kernel.org>, "ML netdev" <netdev@...r.kernel.org>, "Greg Rose" <gregory.v.rose@...el.com>, "Maxime Bizon" <mbizon@...ebox.fr>, "Kristoffer Glembo" <kristoffer@...sler.com>, "Ralf Baechle" <ralf@...ux-mips.org>, "John Linn" <john.linn@...inx.com>, "Randy Dunlap" <randy.dunlap@...cle.com>, "David S. Miller" <davem@...emloft.net>, "MeeGo" <meego-dev@...go.com>, "Wang, Qi" <qi.wang@...el.com>, "Wang, Yong Y" <yong.y.wang@...el.com>, "Andrew" <andrew.chih.howe.khor@...el.com>, "Intel OTC" <joel.clark@...el.com>, "Foster, Margie" <margie.foster@...el.com>, "Toshiharu Okada" <okada533@....okisemi.com>, "Tomoya Morinaga" <morinaga526@....okisemi.com>, "Takahiro Shimizu" <shimizu394@....okisemi.com> Subject: Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH Hi Eric Thank you for your information. I will confirm other drivers. Thanks, Ohtake(OKISemi) ----- Original Message ----- From: "Eric Dumazet" <eric.dumazet@...il.com> To: "Masayuki Ohtake" <masa-korg@....okisemi.com> Cc: "Stephen Hemminger" <shemminger@...tta.com>; "Sam Ravnborg" <sam@...nborg.org>; "Joe Perches" <joe@...ches.com>; "LKML" <linux-kernel@...r.kernel.org>; "ML netdev" <netdev@...r.kernel.org>; "Greg Rose" <gregory.v.rose@...el.com>; "Maxime Bizon" <mbizon@...ebox.fr>; "Kristoffer Glembo" <kristoffer@...sler.com>; "Ralf Baechle" <ralf@...ux-mips.org>; "John Linn" <john.linn@...inx.com>; "Randy Dunlap" <randy.dunlap@...cle.com>; "David S. Miller" <davem@...emloft.net>; "MeeGo" <meego-dev@...go.com>; "Wang, Qi" <qi.wang@...el.com>; "Wang, Yong Y" <yong.y.wang@...el.com>; "Andrew" <andrew.chih.howe.khor@...el.com>; "Intel OTC" <joel.clark@...el.com>; "Foster, Margie" <margie.foster@...el.com>; "Toshiharu Okada" <okada533@....okisemi.com>; "Tomoya Morinaga" <morinaga526@....okisemi.com>; "Takahiro Shimizu" <shimizu394@....okisemi.com> Sent: Friday, September 03, 2010 10:43 PM Subject: Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH > Le vendredi 03 septembre 2010 a 22:32 +0900, Masayuki Ohtake a ecrit : > > Hi Eric and Stephen > > > > Thank you for your suggestion. > > > > I tried modification of "dev->hard_header_len". > > However, there was no changed to a format of SKB received by kernel. > > [Header:14octet] + [payload] > > > > So, I can not a single memcpy. > > Hmm, maybe you did this at the wrong place ? > > Take a look at other drivers how they do this > > (network stack default hard_header_len to 14, in net/ethernet/eth.c, > function ether_setup()) > > > find drivers/net | xargs grep -n hard_header_len > > Example in drivers/net/wan/hdlc.c > > static void hdlc_setup_dev(struct net_device *dev) > { > /* Re-init all variables changed by HDLC protocol drivers, > * including ether_setup() called from hdlc_raw_eth.c. > */ > dev->flags = IFF_POINTOPOINT | IFF_NOARP; > dev->priv_flags = IFF_WAN_HDLC; > dev->mtu = HDLC_MAX_MTU; > dev->type = ARPHRD_RAWHDLC; > dev->hard_header_len = 16; > dev->addr_len = 0; > dev->header_ops = &hdlc_null_ops; > } > > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists