| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 7 Sep 2010 10:13:22 +0900
From: "Masayuki Ohtake" <masa-korg@....okisemi.com>
To: "FUJITA Tomonori" <fujita.tomonori@....ntt.co.jp>
Cc: <shemminger@...tta.com>, <sam@...nborg.org>, <joe@...ches.com>,
"ML linux-kernel" <linux-kernel@...r.kernel.org>,
"ML netdev" <netdev@...r.kernel.org>, <gregory.v.rose@...el.com>,
<mbizon@...ebox.fr>, <kristoffer@...sler.com>,
<ralf@...ux-mips.org>, <john.linn@...inx.com>,
<randy.dunlap@...cle.com>, <davem@...emloft.net>,
<meego-dev@...go.com>, "Wang, Qi" <qi.wang@...el.com>,
"Wang, Yong Y" <yong.y.wang@...el.com>,
<andrew.chih.howe.khor@...el.com>,
"Intel OTC" <joel.clark@...el.com>,
"Foster, Margie" <margie.foster@...el.com>,
"okada" <okada533@....okisemi.com>,
"Morinaga" <morinaga526@....okisemi.com>,
"shimizu" <shimizu394@....okisemi.com>
Subject: Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH
Hi Fujita
Thank you for your comments.
> > + if (buffer_info->dma) {
> > + pci_unmap_single(adapter->pdev, buffer_info->dma,
> > + buffer_info->length, PCI_DMA_FROMDEVICE);
> > + buffer_info->dma = 0;
>
> Probably, this trick doesn't work because zero could be a valid DMA
> address on some architctures.
>
The flag which shows mapped will be added.
And it is used instead of "if (buffer_info->dma) ".
> > + /*-- Set Buffer infomation --*/
> > + buffer_info->length = skb->len;
> > + buffer_info->dma =
> > + pci_map_single(adapter->pdev, skb->data, buffer_info->length,
> > + PCI_DMA_TODEVICE);
>
> Needs to handle mapping failure (dma_mapping_errro)?
Error process will be added.
> Can you use dma_map_* API instead of pci_map_*? Please read:
>
This DMA of device is not standard. Personal use of Gigabit Ethernet device.
So, I guess that I do not need to use DMA-API.
Thanks, Ohtake
----- Original Message -----
From: "FUJITA Tomonori" <fujita.tomonori@....ntt.co.jp>
To: <masa-korg@....okisemi.com>
Cc: <shemminger@...tta.com>; <sam@...nborg.org>; <joe@...ches.com>; <linux-kernel@...r.kernel.org>;
<netdev@...r.kernel.org>; <gregory.v.rose@...el.com>; <mbizon@...ebox.fr>; <kristoffer@...sler.com>;
<ralf@...ux-mips.org>; <john.linn@...inx.com>; <randy.dunlap@...cle.com>; <davem@...emloft.net>; <meego-dev@...go.com>;
<qi.wang@...el.com>; <yong.y.wang@...el.com>; <andrew.chih.howe.khor@...el.com>; <joel.clark@...el.com>;
<margie.foster@...el.com>; <okada533@....okisemi.com>; <morinaga526@....okisemi.com>; <shimizu394@....okisemi.com>
Sent: Friday, September 03, 2010 11:23 AM
Subject: Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH
> On Tue, 31 Aug 2010 23:15:22 +0900
> Masayuki Ohtake <masa-korg@....okisemi.com> wrote:
>
> > Gigabit Ethernet driver of Topcliff PCH
> > Patch created against 2.6.35
> >
> > Topcliff PCH is the platform controller hub that is going to be used in
> > Intel's upcoming general embedded platform. All IO peripherals in
> > Topcliff PCH are actually devices sitting on AMBA bus.
> > Topcliff PCH has Gigabit Ethernet I/F. Using this I/F, it is able to
> > access system devices connected to Gigabit Ethernet.
> >
> > Signed-off-by: Masayuki Ohtake <masa-korg@....okisemi.com>
> > ---
> > drivers/net/Kconfig | 10 +
> > drivers/net/Makefile | 1 +
> > drivers/net/pch_gbe/Makefile | 4 +
> > drivers/net/pch_gbe/pch_gbe.h | 683 +++++++++
> > drivers/net/pch_gbe/pch_gbe_api.c | 246 ++++
> > drivers/net/pch_gbe/pch_gbe_api.h | 34 +
> > drivers/net/pch_gbe/pch_gbe_ethtool.c | 618 ++++++++
> > drivers/net/pch_gbe/pch_gbe_main.c | 2591 +++++++++++++++++++++++++++++++++
> > drivers/net/pch_gbe/pch_gbe_param.c | 519 +++++++
> > drivers/net/pch_gbe/pch_gbe_phy.c | 276 ++++
> > drivers/net/pch_gbe/pch_gbe_phy.h | 35 +
> > 11 files changed, 5017 insertions(+), 0 deletions(-)
> > create mode 100644 drivers/net/pch_gbe/Makefile
> > create mode 100644 drivers/net/pch_gbe/pch_gbe.h
> > create mode 100644 drivers/net/pch_gbe/pch_gbe_api.c
> > create mode 100644 drivers/net/pch_gbe/pch_gbe_api.h
> > create mode 100644 drivers/net/pch_gbe/pch_gbe_ethtool.c
> > create mode 100644 drivers/net/pch_gbe/pch_gbe_main.c
> > create mode 100644 drivers/net/pch_gbe/pch_gbe_param.c
> > create mode 100644 drivers/net/pch_gbe/pch_gbe_phy.c
> > create mode 100644 drivers/net/pch_gbe/pch_gbe_phy.h
>
> (snip)
>
> > +/**
> > + * pch_gbe_unmap_and_free_rx_resource - Unmap and free rx socket buffer
> > + * @adapter: Board private structure
> > + * @buffer_info: Buffer information structure
> > + */
> > +static void pch_gbe_unmap_and_free_rx_resource(
> > + struct pch_gbe_adapter *adapter,
> > + struct pch_gbe_buffer *buffer_info)
> > +{
> > + if (buffer_info->dma) {
> > + pci_unmap_single(adapter->pdev, buffer_info->dma,
> > + buffer_info->length, PCI_DMA_FROMDEVICE);
> > + buffer_info->dma = 0;
>
> Probably, this trick doesn't work because zero could be a valid DMA
> address on some architctures.
>
>
> > + /*-- Set Buffer infomation --*/
> > + buffer_info->length = skb->len;
> > + buffer_info->dma =
> > + pci_map_single(adapter->pdev, skb->data, buffer_info->length,
> > + PCI_DMA_TODEVICE);
>
> Needs to handle mapping failure (dma_mapping_errro)?
>
> I found the same problems in other places.
>
>
> Can you use dma_map_* API instead of pci_map_*? Please read:
>
> Documentation/DMA-API.txt
> Documentation/DMA-API-HOWTO.txt
>
>
> Thanks,
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists