netdev - Re: [PATCH 4/7 v3] au1000-eth: fix bad printk usages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Sep 2010 14:24:51 -0700
From:	Joe Perches <joe@...ches.com>
To:	Florian Fainelli <florian@...nwrt.org>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: Re: [PATCH 4/7 v3] au1000-eth: fix bad printk usages

On Wed, 2010-09-08 at 23:11 +0200, Florian Fainelli wrote:
diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
> @@ -1199,7 +1203,8 @@ static int __devinit au1000_probe(struct platform_device *pdev)
>  	netdev_info(dev, "Au1xx0 Ethernet found at 0x%lx, irq %d\n",
>  			(unsigned long)base->start, irq);
>  	if (version_printed++ == 0)
> -		printk("%s version %s %s\n", DRV_NAME, DRV_VERSION, DRV_AUTHOR);
> +		pr_info("%s version %s %s\n",
> +					DRV_NAME, DRV_VERSION, DRV_AUTHOR);

You could also remove version_printed and use
printk_once(KERN_INFO etc...)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html