netdev - Re: [PATCH v3 00/10] split out emac cpdma and mdio for reuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 09 Sep 2010 14:43:12 -0400
From:	Michael Williamson <michael.williamson@...ticallink.com>
To:	cyril@...com
CC:	Kevin Hilman <khilman@...prootsystems.com>,
	"tony@...mide.com" <tony@...mide.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH v3 00/10] split out emac cpdma and mdio for reuse

On 9/8/2010 8:47 PM, Michael Williamson wrote:

> Hi Cyril,
> 
> On 09/08/2010 05:59 PM, Cyril Chemparathy wrote:
>> Hi Mike,
>>
> 
> So I went in and set the debug_level to netif_msg_init() to -1 in the davinci_emac
> driver.  The only thing I get during the boot process is:
> 
> net eth0: DaVinci EMAC Probe found device (regs: 01e23000, irq: 33)
> 
> which is good (I also added some debug to make sure probe actually completes), but
> I don't see *anything* else.  I guess I would have expected to see something out of 
> the emac_dev_open.  So I added some more debug in there, it's hanging in the 
> phy_connect() call.  The phy_id it came up with was correct "0:03".
> 
> 

The hang is in wait_for_user_access() in the davinci_mdio_read() call.  Looks like
the state machine got put back into IDLE somewhere between the MDIO probe and the 
EMAC probe. Seems like there should be some sort of time-out and error message 
in the wait_for_user_access() method.... (maybe even a check for IDLE??)

If I add a patch to check the state machine for IDLE and then re-enable it in the
davinci_mdio_read() call, it is able to press on and come up.  I don't see any calls
to the davinci_mdio_suspend() call, so I am wondering if the EMAC probe routine, 
particularly the application of the SOFTRESET, is causing the MDIO to drop back to 
IDLE / disabled.

I can post the patch if you like, but it is a bit of a hack...

-Mike
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html