netdev - Re: [PATCH] vlan: enable GRO if real

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Sep 2010 11:59:04 -0700
From:	Brandon Philips <bphilips@...e.de>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, jeffrey.t.kirsher@...el.com,
	jesse.brandeburg@...el.com, bruce.w.allan@...el.com,
	alexander.h.duyck@...el.com, peter.p.waskiewicz.jr@...el.com,
	john.ronciak@...el.com, donald.c.skidmore@...el.com,
	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH] vlan: enable GRO if real_dev supports it

On 19:08 Wed 15 Sep 2010, Eric Dumazet wrote:
> Le mercredi 15 septembre 2010 à 09:37 -0700, Brandon Philips a écrit :
> > Currently vlan devices don't have GRO by default as none of the Ethernet
> > drivers add NETIF_F_GRO to their vlan_features.
> > 
> > As GRO is a software feature just propogate GRO from the real_dev in the
> > vlan core. There is no need to have the drivers each add NETIF_F_GRO to
> > their vlan_features.
> > 
> > Signed-off-by: Brandon Philips <bphilips@...e.de>
> > ---
> >  net/8021q/vlan_dev.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
> > index 3bccdd1..6fbc445 100644
> > --- a/net/8021q/vlan_dev.c
> > +++ b/net/8021q/vlan_dev.c
> > @@ -735,6 +735,7 @@ static int vlan_dev_init(struct net_device *dev)
> >  					  (1<<__LINK_STATE_DORMANT))) |
> >  		      (1<<__LINK_STATE_PRESENT);
> >  
> > +	dev->features |= real_dev->features & NETIF_F_GRO;
> >  	dev->features |= real_dev->features & real_dev->vlan_features;
> >  	dev->gso_max_size = real_dev->gso_max_size;
> >  
> 
> Hmm, this is only part of a generic solution.
> 
> If I enable gro with "ethtool -K eth0 gro on", should we propagate GRO
> on vlan eth0.555 ?

That works fine as far as I can see. I don't think it should go the
other way though. 

Cheers, Brandon
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html