netdev - Re: SPARC32 SMP 2.6.36-rc3 build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 15 Sep 2010 09:20:00 +0200
From:	Daniel Hellstrom <daniel@...sler.com>
To:	David Miller <davem@...emloft.net>
CC:	sparclinux@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: SPARC32 SMP 2.6.36-rc3 build error


David Miller wrote:

>From: Daniel Hellstrom <daniel@...sler.com>
>Date: Tue, 14 Sep 2010 15:30:27 +0200
>
>  
>
>>I have problems linking Linux SPARC32 when SMP is enabled:
>>
>> LD      vmlinux
>> SYSMAP  System.map
>> SYSMAP  .tmp_System.map
>> BTFIX   arch/sparc/boot/btfix.S
>> AS      arch/sparc/boot/btfix.o
>> LD      arch/sparc/boot/image
>>net/built-in.o: In function `net_rps_action_and_irq_enable':
>>/home/daniel/linux/linux/linux-2.6/net/core/dev.c:3337: undefined
>>reference to `__smp_call_function_single'
>>make[1]: *** [arch/sparc/boot/image] Error 1
>>make: *** [zImage] Error 2
>>    
>>
>
>It's a missing dependency in the networking code, I'll fix this
>in the net-2.6 tree as follows:
>
>--------------------
>net: RPS needs to depend upon USE_GENERIC_SMP_HELPERS
>
>You cannot invoke __smp_call_function_single() unless the
>architecture sets this symbol.
>
>Reported-by: Daniel Hellstrom <daniel@...sler.com>
>Signed-off-by: David S. Miller <davem@...emloft.net>
>---
> net/Kconfig |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/net/Kconfig b/net/Kconfig
>index e330594..e926884 100644
>--- a/net/Kconfig
>+++ b/net/Kconfig
>@@ -217,7 +217,7 @@ source "net/dns_resolver/Kconfig"
> 
> config RPS
> 	boolean
>-	depends on SMP && SYSFS
>+	depends on SMP && SYSFS && USE_GENERIC_SMP_HELPERS
> 	default y
> 
> menu "Network testing"
>  
>

That resolved the problem nicely.

Thank you very much,
Daniel

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html