netdev - Re: [PATCH RESEND 1/3] netfilter: xtables: inclusion of xt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Sep 2010 07:38:09 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Jan Engelhardt <jengelh@...ozas.de>
CC:	Luciano Coelho <luciano.coelho@...ia.com>,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
	sameo@...ux.intel.com, janne.ylalehto@...ia.com
Subject: Re: [PATCH RESEND 1/3] netfilter: xtables: inclusion of xt_condition

On 15.09.2010 23:09, Jan Engelhardt wrote:
> 
> On Wednesday 2010-09-15 22:59, Patrick McHardy wrote:
>> On 15.09.2010 22:52, Jan Engelhardt wrote:
>>>
>>> On Wednesday 2010-09-15 22:39, Patrick McHardy wrote:
>>>> Am 17.08.2010 10:36, schrieb Luciano Coelho:
>>>>> +/* Defaults, these can be overridden on the module command-line. */
>>>>> +static unsigned int condition_list_perms = S_IRUGO | S_IWUSR;
>>>>> +static unsigned int condition_uid_perms = 0;
>>>>> +static unsigned int condition_gid_perms = 0;
>>>>
>>>> I'm not sure whether we already discussed this, but this isn't
>>>> useful if namespaces are used since the IDs aren't global.
>>>
>>> Well it's also done for other xt modules that offer a procfs interface.
>>> It does not really cost much to have this present I'd say.
>>
>> They should simply set the permissions for the current namespace.
>>
> IIRC, the namespace stuff was going to be a later patch to keep
> early patches simpler.

I'm fine with that as long as its done before merging the patches
upstream.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html