netdev - Re: [E1000-devel] [PATCH] net: enable GRO by default for vlan devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Sep 2010 23:38:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	eric.dumazet@...il.com, bphilips@...e.de,
	e1000-devel@...ts.sourceforge.net, bruce.w.allan@...el.com,
	jesse.brandeburg@...el.com, john.ronciak@...el.com,
	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	bhutchings@...arflare.com
Subject: Re: [E1000-devel] [PATCH] net: enable GRO by default for vlan
 devices

From: Stephen Hemminger <shemminger@...tta.com>
Date: Wed, 15 Sep 2010 23:21:25 -0700

> I think it is more complex than that. GRO is tied to NAPI,
> and bridge/bond don't use NAPI directly. They use netif_rx() for receiving
> because layered drivers can't directly up call because of possible
> issues with stack depth. 
> 
> To get GRO working for netif_rx case,
> the logic in process_backlog would have to change.
> But this queue is processing packets from multiple devices so
> it is not clear if GRO could be used.

Bonding's un-layering on RX is done in the normal netif_receive_skb()
control flow.

And bridging only uses netif_rx for multicast replication.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html