netdev - Re: [PATCH NEXT 1/5] qlcnic: support vlan rx accleration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Sep 2010 15:26:10 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Amit Kumar Salecha <amit.salecha@...gic.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	ameen.rahman@...gic.com, anirban.chakraborty@...gic.com
Subject: Re: [PATCH NEXT 1/5] qlcnic: support vlan rx accleration

Le jeudi 16 septembre 2010 à 06:14 -0700, Amit Kumar Salecha a écrit :

>  	skb->protocol = eth_type_trans(skb, netdev);
>  
> -	napi_gro_receive(&sds_ring->napi, skb);
> +	if ((vid != 0xffff) && adapter->vlgrp)
> +		vlan_hwaccel_receive_skb(skb, adapter->vlgrp, vid);
> +	else
> +		napi_gro_receive(&sds_ring->napi, skb);

This seems very strange to use GRO only on non tagged trafic.

I understand you want to have a separate patch (2/5) for GRO & vlans,
but this seems a bit convoluted.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html