lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Sep 2010 14:18:38 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: Amit Salecha <amit.salecha@...gic.com> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Ameen Rahman <ameen.rahman@...gic.com>, Anirban Chakraborty <anirban.chakraborty@...gic.com>, David Miller <davem@...emloft.net> Subject: RE: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2 Le lundi 20 septembre 2010 à 06:16 -0500, Amit Salecha a écrit : > This can be cleaned up. > Though I have one doubt. We are allocating larger packets than the actual data used. > Doesn't it will break accounting ? truesize accounts for the real size of buffers, not the used part in them. IMHO, a driver not dealing with fragments should not touch skb->truesize # grep truesize drivers/net/tg3.c <nothing> If a driver deals with fragments, it probably should use "+=" operator only, not hardcoding sizeof(struct sk_buff) thing that only core network has to deal with. $ find drivers/net/bnx2x|xargs grep truesize drivers/net/bnx2x/bnx2x_cmn.c: skb->truesize += frag_len; Almost all drivers are fine, they are some of them that should be changed. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists