netdev - Re: [PATCH net-next2.6] drivers/net: more return operator cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 24 Sep 2010 19:56:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next2.6] drivers/net: more return operator cleanup

From: Joe Perches <joe@...ches.com>
Date: Fri, 24 Sep 2010 17:03:34 -0700

> Change "return (EXPR);" to "return EXPR;"
> 
> return is not a function, parentheses are not required.
> 
> drivers/net/wireless excluded.
> Most whitespace errors on same line as return fixed.
> 
> Done via script with some manual multi-line aligning.
> Compile tested x86 only, not all files compiled.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Joe, you're really starting to tick me off.

Why in the world are you subsuming this set of changes which Eric
Dumazet has already made already, and on top of it not giving him any
credit in the commit message?

And you're doing this after bugging the crap out of me by asking me to
hurry up with applying Eric's patch in a totally inappropriate private
email?

You have to be joking.

Look, if there is anything in my queue in patchwork, it means I am
backlogged.

And when I'm backlogged I prioritize.  And how I prioritize to get my
head back above water and on top of the queue again is my business.

The last thing you should do is try to preempt other things like
important crash fixes by asking me to hurry up with a cleanup
patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html