lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 2 Oct 2010 16:21:23 +0200 (CEST) From: Julia Lawall <julia@...u.dk> To: walter harms <wharms@....de> Cc: Chas Williams <chas@....nrl.navy.mil>, kernel-janitors@...r.kernel.org, linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 4/4] drivers/atm/idt77252.c: Remove unnecessary error check On Sat, 2 Oct 2010, walter harms wrote: > > > Julia Lawall schrieb: > > This code does not call deinit_card(card); in an error case, as done in > > other error-handling code in the same function. But actually, the called > > function init_sram can only return 0, so there is no need for the error > > check at all. > > > > > did you set init_sram() to void ? No, that indeed seems like a reasonable change. Patch shortly. julia -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists