lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 03 Oct 2010 22:06:25 -0700 (PDT) From: David Miller <davem@...emloft.net> To: julia@...u.dk Cc: wharms@....de, chas@....nrl.navy.mil, kernel-janitors@...r.kernel.org, linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 4/4] drivers/atm/idt77252.c: Remove unnecessary error check From: Julia Lawall <julia@...u.dk> Date: Sat, 2 Oct 2010 16:37:07 +0200 (CEST) > This code does not call deinit_card(card); in an error case, as done in > other error-handling code in the same function. But actually, the called > function init_sram can only return 0, so there is no need for the error > check at all. > > init_sram is also given a void return type, and its single return statement > at the end of the function is dropped. > > A simplified version of the sematic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) ... > Signed-off-by: Julia Lawall <julia@...u.dk> Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists