netdev - Re: [PATCH] tms380tr: fix long delays in initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 03 Oct 2010 20:01:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mroos@...ux.ee
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] tms380tr: fix long delays in initialization

From: Meelis Roos <mroos@...ux.ee>
Date: Sun, 3 Oct 2010 22:34:30 +0300 (EEST)

> tms380tr driver tries to use udelay (meaning busy loop) for several half 
> second delays during hardware initialization. Crazy overly long busy 
> wait delays mean no delay at all so driver initialization fails without 
> waiting. Fix it by using msleep() for long delays and leave it to 
> udelay() for short delays.
> 
> Signed-off-by: Meelis Roos <mroos@...ux.ee>

You can't use msleep() here because this code can be invoked
from interrupts and thus cannot sleep.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html