lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 07 Oct 2010 12:06:44 +0200 From: Jesper Dangaard Brouer <hawk@...x.dk> To: David Miller <davem@...emloft.net> Cc: eric.dumazet@...il.com, netdev@...r.kernel.org, jeffrey.t.kirsher@...el.com Subject: Re: [net-next PATCH] igb: update adapter stats when reading /proc/net/dev. On Wed, 2010-10-06 at 23:46 -0700, David Miller wrote: > From: Eric Dumazet <eric.dumazet@...il.com> > Date: Thu, 07 Oct 2010 08:44:08 +0200 > > > Le mercredi 06 octobre 2010 à 23:36 -0700, David Miller a écrit : > >> From: Jesper Dangaard Brouer <hawk@...x.dk> > >> Date: Tue, 05 Oct 2010 16:18:33 +0200 > >> > >> > Network driver igb: Improve the accuracy of stats in /proc/net/dev, by > >> > updating the adapter stats when reading /proc/net/dev. Currently the > >> > stats are updated by the watchdog timer every 2 sec, or when getting > >> > stats via ethtool -S. > >> > > >> > A number of userspace apps read these /proc/net/dev stats every second, > >> > e.g. ifstat, which then gives a perceived very bursty traffic pattern, > >> > which is actually false. > >> > > >> > Signed-off-by: Jesper Dangaard Brouer <hawk@...x.dk> > >> > >> I assume that the Intel folks will take care of integrating this > >> now that the locking is fixed. > > > > I integrated Jesper patch into my cumulative patch. > > Ok. I'm fine with this, as long as the commit message describe this change of accuracy of stats in /proc/net/dev. Something like: This patch also increase the accuracy of stats in /proc/net/dev, by updating the adapter stats when reading /proc/net/dev. Previously the stats were only updated by the watchdog timer every 2 sec, which resulted in false observations from userspace. -- Med venlig hilsen / Best regards Jesper Brouer ComX Networks A/S Linux Network Kernel Developer Cand. Scient Datalog / MSc.CS Author of http://adsl-optimizer.dk LinkedIn: http://www.linkedin.com/in/brouer -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists