netdev - Re: [patch] isdn: strcpy() => strlcpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 08 Oct 2010 10:23:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	error27@...il.com
Cc:	viro@...IV.linux.org.uk, isdn@...ux-pingi.de,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] isdn: strcpy() => strlcpy()

From: Dan Carpenter <error27@...il.com>
Date: Wed, 6 Oct 2010 07:17:35 +0200

> setup.phone and setup.eazmsn are 32 character buffers.
> rcvmsg.msg_data.byte_array is a 48 character buffer.
> sc_adapter[card]->channel[rcvmsg.phy_link_no - 1].dn is 50 chars.
> 
> The rcvmsg struct comes from the memcpy_fromio() in receivemessage().
> I guess that means it's data off the wire.  I'm not very familiar with
> this code but I don't see any reason to assume these strings are NULL
> terminated.
> 
> Also it's weird that "dn" in a 50 character buffer but we only seem to
> use 32 characters.  In drivers/isdn/sc/scioc.h, "dn" is only a 49
> character buffer.  So potentially there is still an issue there.
> 
> The important thing for now is to prevent the memory corruption.
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>

Applied, thanks Dan.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html