| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Oct 2010 21:46:01 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: David Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org Subject: Re: [PATCH net-next] neigh: speedup neigh_resolve_output() Le lundi 11 octobre 2010 à 12:16 -0700, David Miller a écrit : > From: Eric Dumazet <eric.dumazet@...il.com> > Date: Thu, 07 Oct 2010 22:44:07 +0200 > > > Le jeudi 07 octobre 2010 à 14:53 +0200, Eric Dumazet a écrit : > > > >> Further improvements would need to use a seqlock instead of an rwlock to > >> protect neigh->ha[], to not dirty neigh too often and remove two atomic > >> ops. > >> > > > > I implemented this idea in following patch, on top on previous one. > > > > [PATCH net-next] neigh: speedup neigh_resolve_output() > > So Eric do you think this is more efficient than the idea I > proposed, which is to "cmpxchg 'hh' and RCU"? > > If you think this seqlock thing is faster or more desirable > for some reason, I'll add it. > > Thanks! Hmm, we would need a neigh->ha pointer to some struct, with rcu protection. It adds a dereference in hot path. I believe this seqlock (only for pathological cases, where dst are used for few packets) should be fine. Note: After this patch, I have a "struct neighbour" small field reorg pending, not yet submitted. Thanks -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists