lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Oct 2010 09:46:59 -0700 (PDT) From: David Miller <davem@...emloft.net> To: james@...anarts.com Cc: zambrano@...adcom.com, jpirko@...hat.com, fujita.tomonori@....ntt.co.jp, hauke@...ke-m.de, Larry.Finger@...inger.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] b44: fix resume, request_irq after hw reset From: James Hogan <james@...anarts.com> Date: Tue, 12 Oct 2010 00:22:12 +0100 > @@ -2309,6 +2303,12 @@ static int b44_resume(struct ssb_device *sdev) > netif_device_attach(bp->dev); > spin_unlock_irq(&bp->lock); > > + rc = request_irq(dev->irq, b44_interrupt, IRQF_SHARED, dev->name, dev); > + if (rc) { > + netdev_err(dev, "request_irq failed\n"); > + return rc; > + } > + > b44_enable_ints(bp); > netif_wake_queue(dev); Since you've moved the request_irq() down, you'll need to adjust the error handling so that it undoes side effects made by this function up until this point. F.e. netif_device_attach() has to be undone for one thing. Next, b44_init_rings() allocates memory that you must now free. Etc. etc. etc. This change is not so simple. :-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists