netdev - Re: [patch] ns83820: spin_lock_irq() => spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 18 Oct 2010 01:53:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	error27@...il.com
Cc:	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
	mingo@...e.hu
Subject: Re: [patch] ns83820: spin_lock_irq() => spin_lock()

From: Dan Carpenter <error27@...il.com>
Date: Wed, 13 Oct 2010 21:18:53 +0200

> This is essentially cosmetic.  At this point the IRQs are already
> disabled because we called spin_lock_irq(&dev->rx_info.lock).
> 
> The real bug here was fixed back in 2006 in 3a10ccebe: "[PATCH] lock
> validator: fix ns83820.c irq-flags bug".  Prior to that patch, it was
> a "spin_lock_irq is not nestable" type bug.  The 2006 patch changes the
> unlock to not re-enable IRQs, which eliminates the potential deadlock.
> 
> But this bit was missed.  We should change the lock function as well so
> it balances nicely.
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html