netdev - [PATCH] bonding: minor cleanups to bond + netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Oct 2010 13:04:24 -0400
From:	nhorman@...driver.com
To:	netdev@...r.kernel.org
Cc:	bonding-devel@...ts.sourceforge.net, fubar@...ibm.com,
	davem@...emloft.net, andy@...yhouse.net, amwang@...hat.com,
	nhorman@...driver.com
Subject: [PATCH] bonding: minor cleanups to bond + netpoll

Testing that was onging when the the reset patchset to enable netpoll over
bonding revealed some minor corner cases that are worth correcting.  In summary:

1) Remove netpoll tx blocking from bond_release_all.  Its not needed and causes
some uglyness when removing the bonding module, in the form of a backtrace that
gets logged.  blocking isn't needed in this path anyway as the netconsole is
already unregistered from us at this point

2) Remove my changes to napi_poll.  Closer inspection of the bonding
poll_controller show that we wind up recursively calling the napi poll routines
for the slaves through sucsessive calls to netpoll_poll_dev.  My origional
change is harmless, but its not really needed, so lets make the code simpler.

Further details available in the individual commit messages

Signed-off-by: Neil Horman <nhorman@...driver.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html