netdev - Re: [PATCH 3/3] vmxnet3: fix typo setting confPA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 24 Oct 2010 15:44:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	harvey.harrison@...il.com
Cc:	sbhatewara@...are.com, netdev@...r.kernel.org,
	shemminger@...tta.com
Subject: Re: [PATCH 3/3] vmxnet3: fix typo setting confPA

From: Harvey Harrison <harvey.harrison@...il.com>
Date: Fri, 22 Oct 2010 10:52:15 -0700

> On Fri, Oct 22, 2010 at 10:46 AM, Shreyas Bhatewara
> <sbhatewara@...are.com> wrote:
>>> From: Harvey Harrison [mailto:harvey.harrison@...il.com]
>>> One question I had when looking into this, why are you doing
>>> byteswapping in the VMXNET_{READ,WRITE}_BAR{0,1}
>>> macros?
>>
>> Because values need to be written in LE orders in registers. For eg. when rx_ring.next2fill index is written to RXPROD reg, it should be converted from CPU order to LE.
> 
> Yes, but (unless I'm mistaken) writel always writes out in
> little-endian, so there isn't a need to swap the arguments,
> similarly for readl in the other direction.

That's right, readl() and writel() translate to little-endian.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html