lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Oct 2010 18:40:55 -0700 From: Andy Grover <andy.grover@...cle.com> To: netdev@...r.kernel.org Cc: rds-devel@....oracle.com, Linus Torvalds <torvalds@...ux-foundation.org> Subject: [PATCH 1/5] net: fix rds_iovec page count overflow From: Linus Torvalds <torvalds@...ux-foundation.org> As reported by Thomas Pollet, the rdma page counting can overflow. We get the rdma sizes in 64-bit unsigned entities, but then limit it to UINT_MAX bytes and shift them down to pages (so with a possible "+1" for an unaligned address). So each individual page count fits comfortably in an 'unsigned int' (not even close to overflowing into signed), but as they are added up, they might end up resulting in a signed return value. Which would be wrong. Catch the case of tot_pages turning negative, and return the appropriate error code. Reported-by: Thomas Pollet <thomas.pollet@...il.com> Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org> Signed-off-by: Andy Grover <andy.grover@...cle.com> --- net/rds/rdma.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/net/rds/rdma.c b/net/rds/rdma.c index 1a41deb..0df02c8 100644 --- a/net/rds/rdma.c +++ b/net/rds/rdma.c @@ -502,6 +502,13 @@ static int rds_rdma_pages(struct rds_rdma_args *args) return -EINVAL; tot_pages += nr_pages; + + /* + * nr_pages for one entry is limited to (UINT_MAX>>PAGE_SHIFT)+1, + * so tot_pages cannot overflow without first going negative. + */ + if ((int)tot_pages < 0) + return -EINVAL; } return tot_pages; -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists