lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Oct 2010 01:38:00 -0700 From: Jeff Kirsher <jeffrey.t.kirsher@...el.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: "Tantilov, Emil S" <emil.s.tantilov@...el.com>, David Miller <davem@...emloft.net>, "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>, "Brattain, Ross B" <ross.b.brattain@...el.com>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH] ixgbe: refactor ixgbe_alloc_queues() On Thu, Oct 28, 2010 at 20:45, Eric Dumazet <eric.dumazet@...il.com> wrote: > Note : compiled only patch, not tested. > > Thanks ! > > [PATCH] ixgbe: refactor ixgbe_alloc_queues() > > I noticed ring variable was initialized before allocations, and that > memory node management was a bit ugly. We also leak memory in case of > ring allocations error. > > Signed-off-by: Eric Dumazet <eric.dumazet@...il.com> > --- > drivers/net/ixgbe/ixgbe_main.c | 69 ++++++++++++------------------- > 1 file changed, 28 insertions(+), 41 deletions(-) > I noticed a typo when applying the patch and I fixed it in the patch in my queue. The following code: > + while (rx) > + kfree(adapter->tx_ring[--rx]); > + should be: > + while (rx) > + kfree(adapter->rx_ring[--rx]); > + -- Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists