lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 03 Nov 2010 06:22:53 +0100 From: Eric Dumazet <eric.dumazet@...il.com> To: Xiaotian Feng <dfeng@...hat.com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, "Pekka Savola (ipv6)" <pekkas@...core.fi>, James Morris <jmorris@...ei.org>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, Patrick McHardy <kaber@...sh.net> Subject: Re: [PATCH] net dst: fix percpu_counter list corruption and poison overwritten Le mercredi 03 novembre 2010 à 10:11 +0800, Xiaotian Feng a écrit : > There're some percpu_counter list corruption and poison overwritten warnings > in recent kernel, which is resulted by fc66f95c. > > commit fc66f95c switches to use percpu_counter, in ip6_route_net_init, kernel > init the percpu_counter for dst entries, but, the percpu_counter is never destroyed > in ip6_route_net_exit. So if the related data is freed by kernel, the freed percpu_counter > is still on the list, then if we insert/remove other percpu_counter, list corruption > resulted. Also, if the insert/remove option modifies the ->prev,->next pointer of > the freed value, the poison overwritten is resulted then. > > With the following patch, the percpu_counter list corruption and poison overwritten > warnings disappeared. > > Signed-off-by: Xiaotian Feng <dfeng@...hat.com> > Cc: "David S. Miller" <davem@...emloft.net> > Cc: Alexey Kuznetsov <kuznet@....inr.ac.ru> > Cc: "Pekka Savola (ipv6)" <pekkas@...core.fi> > Cc: James Morris <jmorris@...ei.org> > Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org> > Cc: Patrick McHardy <kaber@...sh.net> > --- Good catch, thanks ! Any reason you didnt Cc me (the author of the patch) ? Acked-by: Eric Dumazet <eric.dumazet@...il.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists