netdev - Re: [PATCH 2/2] r8169: fix sleeping while holding spinlock.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Nov 2010 10:48:00 +1100
From:	Andrew Hendry <andrew.hendry@...il.com>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Daniel J Blueman <daniel.blueman@...il.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [PATCH 2/2] r8169: fix sleeping while holding spinlock.

Was getting this error on boot "BUG: scheduling while atomic:
ethtool/1430/0x00000002" patch fixed them.

Acked-by: Andrew Hendry <andrew.hendry@...il.com>

On Tue, Nov 9, 2010 at 10:23 AM, Francois Romieu <romieu@...zoreil.com> wrote:
> As device_set_wakeup_enable can now sleep, move the call to outside
> the critical section.
>
> Signed-off-by: Daniel J Blueman <daniel.blueman@...il.com>
> Acked-by: Rafael J. Wysocki <rjw@...k.pl>
> ---
>  drivers/net/r8169.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> index 3a0877e..4c4d169 100644
> --- a/drivers/net/r8169.c
> +++ b/drivers/net/r8169.c
> @@ -846,10 +846,10 @@ static int rtl8169_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
>        else
>                tp->features &= ~RTL_FEATURE_WOL;
>        __rtl8169_set_wol(tp, wol->wolopts);
> -       device_set_wakeup_enable(&tp->pci_dev->dev, wol->wolopts);
> -
>        spin_unlock_irq(&tp->lock);
>
> +       device_set_wakeup_enable(&tp->pci_dev->dev, wol->wolopts);
> +
>        return 0;
>  }
>
> --
> 1.7.2.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html