lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Nov 2010 16:11:43 +0300 From: Michael Tokarev <mjt@....msk.ru> To: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp> CC: davem@...emloft.net, eric.dumazet@...il.com, drosenberg@...curity.com, netdev@...r.kernel.org Subject: Re: [PATCH] filter: Optimize instruction revalidation code. 16.11.2010 16:08, Tetsuo Handa wrote: [] > net/core/filter.c | 214 ++++++++++++++++------------------------------------- > 1 files changed, 65 insertions(+), 149 deletions(-) > > diff --git a/net/core/filter.c b/net/core/filter.c > index 23e9b2a..85be3d8 100644 > --- a/net/core/filter.c > +++ b/net/core/filter.c > @@ -383,7 +383,57 @@ EXPORT_SYMBOL(sk_run_filter); > */ > int sk_chk_filter(struct sock_filter *filter, int flen) > { > - struct sock_filter *ftest; > + /* > + * Valid instructions are initialized to non-0. > + * Invalid instructions are initialized to 0. > + */ > + static u16 codes[] = { > + [BPF_ALU|BPF_ADD|BPF_K] = BPF_S_ALU_ADD_K + 1, How about using some "const" there? :) /mjt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists