netdev - Re: [net-2.6 PATCH] be2net: Fix to avoid firmware update when interface is not open.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Nov 2010 09:26:03 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	Sarveshwar.Bandi@...lex.com
Cc:	netdev@...r.kernel.org
Subject: Re: [net-2.6 PATCH] be2net: Fix to avoid firmware update when
 interface is not open.

From: Sarveshwar Bandi <Sarveshwar.Bandi@...lex.com>
Date: Thu, 18 Nov 2010 19:37:56 +0530

> Since interrupts are enabled only when open is called on the interface,
> Attempting a firmware update operation when interface is down could lead to
> partial success or failure of operation. This fix fails the request if
> netif_running is false.
> 
> Signed-off-by: Sarveshwar Bandi <Sarveshwar.Bandi@...lex.com>

These status values you are returning from be_load_fw() go all
the way back to userspace.

Therefore "-1" is not appropriate, and instead you should return
real negative errno error values such as -EINVAL, -ENODEV, and
the like.

Please fix this up and resubmit your patch.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html