netdev - RE: ixgbe dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 22 Nov 2010 20:18:20 -0800
From:	"Skidmore, Donald C" <donald.c.skidmore@...el.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	David Miller <davem@...emloft.net>,
	NetDev <netdev@...r.kernel.org>
Subject: RE: ixgbe dump



>-----Original Message-----
>From: yhlu.kernel@...il.com [mailto:yhlu.kernel@...il.com] On Behalf Of
>Yinghai Lu
>Sent: Monday, November 22, 2010 8:16 PM
>To: Skidmore, Donald C
>Cc: Kirsher, Jeffrey T; Brandeburg, Jesse; David Miller; NetDev
>Subject: Re: ixgbe dump
>
>On Mon, Nov 22, 2010 at 7:31 PM, Skidmore, Donald C
><donald.c.skidmore@...el.com> wrote:
>>
>> Hi Yinghai,
>>
>> I was hoping we could have had this patch pushed upstream sooner, but we
>have quite a few in our internal queue right now.
>>
>> If this doesn't solve your issue please let me know.
>>
>> Thanks,
>> -Don Skidmore <donald.c.skidmore@...el.com>
>>
>>
>>
>>
>> After freeing the rings we were not zeroing out the ring count values.
>> This patch now clears these counts correctly.
>>
>> Reported-by: Yinghai Lu <yinghai@...nel.org>
>> Signed-off-by: Don Skidmore <donald.c.skidmore@...el.com>
>> ---
>>
>>  drivers/net/ixgbe/ixgbe_main.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/ixgbe/ixgbe_main.c
>b/drivers/net/ixgbe/ixgbe_main.c
>> index fbad4d8..eee0b29 100644
>> --- a/drivers/net/ixgbe/ixgbe_main.c
>> +++ b/drivers/net/ixgbe/ixgbe_main.c
>> @@ -4771,6 +4771,9 @@ void ixgbe_clear_interrupt_scheme(struct
>ixgbe_adapter *adapter)
>>                adapter->rx_ring[i] = NULL;
>>        }
>>
>> +       adapter->num_tx_queues = 0;
>> +       adapter->num_rx_queues = 0;
>> +
>>        ixgbe_free_q_vectors(adapter);
>>        ixgbe_reset_interrupt_capability(adapter);
>>  }
>
>OK, that fix the problem.
>
>Thanks
>
>Yinghai

That great to hear.  Hopefully we will be able to get the patch submitted  soon.

Thanks,
-Don
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html