netdev - Re: [PATCH] hso: fix disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 25 Nov 2010 13:52:28 +0100
From:	Johan Hovold <jhovold@...il.com>
To:	Filip Aben <f.aben@...ion.com>
Cc:	davem@...emloft.net, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org, pki@...com.pl, j.dumon@...ion.com
Subject: Re: [PATCH] hso: fix disable_net

On Wed, Nov 24, 2010 at 8:35 PM, Filip Aben <f.aben@...ion.com> wrote:
> The HSO driver incorrectly creates a serial device instead of a net
> device when disable_net is set. It shouldn't create anything for the
> network interface.

Looks good apart from the indentation issue pointed out by Sergei (you
should also
indent the hso_create_net_device line).

As I mentioned in another thread, this was actually suggested about a year ago
but was never accepted due to patch corruption (the other two patches submitted
as part of that series also seem to have been plain wrong, though):

	http://kerneltrap.org/mailarchive/linux-netdev/2009/11/19/6261572

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html