lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Dec 2010 20:02:45 -0800 From: Stephen Hemminger <shemminger@...tta.com> To: Brian Haley <brian.haley@...com> Cc: "Eric W. Biederman" <ebiederm@...ssion.com>, David Miller <davem@...emloft.net>, netdev@...r.kernel.org, Mahesh Kelkar <maheshkelkar@...il.com>, Lorenzo Colitti <lorenzo@...gle.com>, YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>, stable@...nel.org Subject: Re: [PATCH] Fix 2.6.34-rc1 regression in disable_ipv6 support On Thu, 09 Dec 2010 10:28:10 -0500 Brian Haley <brian.haley@...com> wrote: > On 12/08/2010 11:16 PM, Eric W. Biederman wrote: > > Finding the real bug is beyond me right now, but fixing the regression > > in disable_ipv6 is simple. We can just delete ::1 when we bring down > > the loopback interface, and it will be restored automatically when we > > bring the loopback interface back up. > > Hi Eric, > > This would work as well, same check, different way. > > Signed-off-by: Brian Haley <brian.haley@...com> > > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index 23cc8e1..5d16a9d 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -2728,7 +2728,8 @@ static int addrconf_ifdown(struct net_device *dev, int how) > and not link-local, then retain it. */ > if (!how && > (ifa->flags&IFA_F_PERMANENT) && > - !(ipv6_addr_type(&ifa->addr) & IPV6_ADDR_LINKLOCAL)) { > + !(ipv6_addr_type(&ifa->addr) & > + (IPV6_ADDR_LINKLOCAL|IPV6_ADDR_LOOPBACK))) { > list_move_tail(&ifa->if_list, &keep_list); > > /* If not doing DAD on this address, just keep it. */ This patch is cleaner but still fails for the non ::1 address case. # ip addr add 2000:db8::1/64 dev lo # ping6 ::1 -- works # ping6 2000:db8::1 --works # ip li set dev lo down # ping6 ::1 -- does not work (expected) # ping6 2000:db8::1 -- ditto # ip il set dev lo up # ping6 ::1 -- works (good) # ping6 2000:db8::1 -- fails (network unreachable) Looks like connected route is not getting restored correctly, probably because loopback has NOARP flag set. The problem may not be true for just loopback, it may also apply to tunnels. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists