lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Dec 2010 19:07:27 -0800 From: Stephen Hemminger <shemminger@...ux-foundation.org> To: Michał Mirosław <mirq-linux@...e.qmqm.pl> Cc: netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net, Vasanthy Kolluri <vkolluri@...co.com>, Roopa Prabhu <roprabhu@...co.com>, David Wang <dwang2@...co.com>, Andrew Gallatin <gallatin@...i.com>, Brice Goglin <brice@...i.com>, Shreyas Bhatewara <sbhatewara@...are.com>, "VMware, Inc." <pv-drivers@...are.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <eric.dumazet@...il.com>, Jiri Pirko <jpirko@...hat.com>, H Hartley Sweeten <hsweeten@...ionengravers.com>, Jie Yang <Jie.Yang@...eros.com>, Joe Perches <joe@...ches.com> Subject: Re: [PATCH 3/3] net: Fix drivers advertising HW_CSUM feature to use csum_start On Wed, 15 Dec 2010 02:24:08 +0100 (CET) Michał Mirosław <mirq-linux@...e.qmqm.pl> wrote: > Some drivers are using skb_transport_offset(skb) instead of skb->csum_start > for NETIF_F_HW_CSUM offload. This does not matter now, but if someone > implements checksumming of encapsulated packets then this will break silently. > > TSO output paths are left as they are, since they are for IP+TCP only > (might be worth converting though). > > Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl> Which if any of these drivers did you test on real hardware? -- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists