netdev - Re: [RFC PATCH v2] Gemini: Gigabit ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Dec 2010 17:56:58 +0100 (CET)
From:	Hans Ulli Kroll <ulli.kroll@...glemail.com>
To:	Stephen Hemminger <stephen.hemminger@...tta.com>
cc:	Ben Hutchings <bhutchings@...arflare.com>,
	Michał Mirosław <mirq-linux@...e.qmqm.pl>,
	gemini-board-dev@...ts.berlios.de, netdev@...r.kernel.org,
	Christoph Biedl <linux-kernel.bfrz@...chmal.in-ulm.de>,
	Hans Ulli Kroll <ulli.kroll@...glemail.com>
Subject: Re: [RFC PATCH v2] Gemini: Gigabit ethernet driver



On Mon, 27 Dec 2010, Stephen Hemminger wrote:

> 
> 
> ----- Original Message -----
> > On Mon, 2010-12-27 at 20:21 +0100, Hans Ulli Kroll wrote:
> > [...]
> > > BTW:
> > >
> > > Why u64_stats ?
> > > I see only a few driver are using u64_stats.
> > > vlan, br_device and some intel driver
> > > no gigabit driver for marvell devices uses u64_stats
> > 
> > All new net drivers should implement 64-bit stats. net_device_stats is
> > kept for backward compatibility because we couldn't change all the
> > existing drivers at once (it's not a simple change for all of them).
> > 
> > Ben.
> 
> BS. drivers with old stats are fine. 64 bit only really matters
> at higher speed. Anyway, it is the kind of thing that can easily
> be fixed later after driver is merged.
> 
> 

I've readed the Intel driver.

So we must also implement to old net_stats interface, for backward 
compatibility ?

Ulli
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html