lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Dec 2010 11:20:25 -0800 (PST) From: David Miller <davem@...emloft.net> To: jj@...osbits.net Cc: joe@...ches.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, zongxi@...adcom.com, mchan@...adcom.com Subject: Re: [PATCH v2] Broadcom CNIC core network driver: fix mem leak on allocation failures in cnic_alloc_uio_rings() From: Jesper Juhl <jj@...osbits.net> Date: Sun, 26 Dec 2010 21:57:39 +0100 (CET) > We are leaking memory in drivers/net/cnic.c::cnic_alloc_uio_rings() if > either of the calls to dma_alloc_coherent() fail. This patch fixes it by > freeing both the memory allocated with kzalloc() and memory allocated with > previous calls to dma_alloc_coherent() when there's a failure. > > Thanks to Joe Perches <joe@...ches.com> for suggesting a better > implementation than my initial version. > > > Signed-off-by: Jesper Juhl <jj@...osbits.net> ... > + err_dma: > + dma_free_coherent(&udev->pdev->dev, udev->l2_ring_size, > + udev->l2_ring, udev->l2_ring_map); Space before tab in indentation, improperly positioned third argument indentation. I fixed all of this up, but please do not skimp on making sure these details are taken care of when updating your patch in response to feedback. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists