netdev - [PATCH] Typo in comments in include/linux/igmp.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 3 Jan 2011 07:25:10 -0800 (PST)
From:	François-Xavier Le Bail <fx.lebail@...oo.com>
To:	netdev@...r.kernel.org
Subject: [PATCH] Typo in comments in include/linux/igmp.h

Hello,

There is a typo in comments in include/linux/igmp.h:

83 #define IGMP_HOST_MEMBERSHIP_QUERY      0x11    /* From RFC1112 */
84 #define IGMP_HOST_MEMBERSHIP_REPORT     0x12    /* Ditto */
85 #define IGMP_DVMRP                      0x13    /* DVMRP routing */
86 #define IGMP_PIM                        0x14    /* PIM routing */
87 #define IGMP_TRACE                      0x15
88 #define IGMPV2_HOST_MEMBERSHIP_REPORT   0x16    /* V2 version of 0x11 */
89 #define IGMP_HOST_LEAVE_MESSAGE         0x17
90 #define IGMPV3_HOST_MEMBERSHIP_REPORT   0x22    /* V3 version of 0x11 */

The line 88 and 90 are about REPORT messages.
The IGMP_HOST_MEMBERSHIP_REPORT value is 0x12.
So the comment on line 88 must be /* V2 version of 0x12 */,
and the comment on line 90 must be /* V3 version of 0x12 */.

Here is a patch.

Thank you,
Francois-Xavier Le Bail

------------------------------------

diff -ru a/include/linux/igmp.h b/include/linux/igmp.h
--- a/include/linux/igmp.h    2010-08-27 01:47:12.000000000 +0200
+++ b/include/linux/igmp.h    2010-12-15 09:50:47.808363144 +0100
@@ -85,9 +85,9 @@
 #define IGMP_DVMRP            0x13    /* DVMRP routing */
 #define IGMP_PIM            0x14    /* PIM routing */
 #define IGMP_TRACE            0x15
-#define IGMPV2_HOST_MEMBERSHIP_REPORT    0x16    /* V2 version of 0x11 */
+#define IGMPV2_HOST_MEMBERSHIP_REPORT    0x16    /* V2 version of 0x12 */
 #define IGMP_HOST_LEAVE_MESSAGE     0x17
-#define IGMPV3_HOST_MEMBERSHIP_REPORT    0x22    /* V3 version of 0x11 */
+#define IGMPV3_HOST_MEMBERSHIP_REPORT    0x22    /* V3 version of 0x12 */
 
 #define IGMP_MTRACE_RESP        0x1e
 #define IGMP_MTRACE            0x1f





      
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html