netdev - Re: [PATCH] atl1: fix oops when changing tx/rx ring params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 03 Jan 2011 11:04:52 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jcliburn@...il.com
Cc:	netdev@...r.kernel.org, stable@...nel.org, jussuf@...ux.ee,
	chris.snook@...il.com, kronos.it@...il.com, Xiong.Huang@...eros.com
Subject: Re: [PATCH] atl1: fix oops when changing tx/rx ring params

From: "J. K. Cliburn" <jcliburn@...il.com>
Date: Sat, 1 Jan 2011 09:02:12 -0600

> Commit 3f5a2a713aad28480d86b0add00c68484b54febc zeroes out the statistics
> message block (SMB) and coalescing message block (CMB) when adapter ring
> resources are freed.  This is desirable behavior, but, as a side effect,
> the commit leads to an oops when atl1_set_ringparam() attempts to alter
> the number of rx or tx elements in the ring buffer (by using ethtool
> -G, for example).  We don't want SMB or CMB to change during this
> operation.
> 
> Modify atl1_set_ringparam() to preserve SMB and CMB when changing ring
> parameters.
> 
> Cc: stable@...nel.org
> Signed-off-by: Jay Cliburn <jcliburn@...il.com>
> Reported-by: Tõnu Raitviir <jussuf@...ux.ee>

I'll apply this, thanks Jay.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html