lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 07 Jan 2011 20:37:10 -0800 (PST) From: David Miller <davem@...emloft.net> To: paulus@...ba.org Cc: xiaosuo@...il.com, harvey.harrison@...il.com, linux-ppp@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH v2] net: ppp: use {get,put}_unaligned_be{16,32} From: Paul Mackerras <paulus@...ba.org> Date: Sat, 8 Jan 2011 14:13:20 +1100 > On Fri, Jan 07, 2011 at 05:15:34PM -0800, David Miller wrote: > >> I have to say that every time I go read the header parsing code in the >> PPP driver, I absolutely regret it. >> >> And Changli's patch fixes some of the readability problems. > > It's up to you whether you merge the patch or not, but surely you > agree it needs more than a zero-line description? It's entire sufficient to me. He de-open-coded {get,put}_unaligned_be{16,32}() and when open-coding is eliminated in this way a commit message of "Use {helper function foo}." is more than enough. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists