lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 24 Jan 2011 16:07:05 +0800 From: Po-Yu Chuang <ratbert.chuang@...il.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, bhutchings@...arflare.com, joe@...ches.com, dilinger@...ued.net, mirqus@...il.com, Po-Yu Chuang <ratbert@...aday-tech.com> Subject: Re: [PATCH v4] net: add Faraday FTMAC100 10/100 Ethernet driver Dear Eric, On Fri, Jan 21, 2011 at 5:08 PM, Eric Dumazet <eric.dumazet@...il.com> wrote: > Le vendredi 21 janvier 2011 à 15:55 +0800, Po-Yu Chuang a écrit : > ... >> + >> + dma_unmap_single(priv->dev, map, skb_headlen(skb), DMA_TO_DEVICE); >> + >> + dev_kfree_skb_irq(skb); >> + >> + ftmac100_txdes_reset(txdes); >> + >> + ftmac100_tx_clean_pointer_advance(priv); >> + >> + priv->tx_pending--; >> + netif_wake_queue(netdev); >> + >> + return true; >> +} >> + > > Thanks to NAPI, you can free skb directly, not queuing it via > NET_TX_SOFTIRQ softirq, using dev_kfree_skb() instead of > dev_kfree_skb_irq() Fixed. Thanks a lot. best regards, Po-Yu Chuang -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists