netdev - Re: [PATCH 18/79] IPVS: Remove useless { } block from ip_vs_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 25 Jan 2011 15:16:04 +1000
From:	Simon Horman <horms@...ge.net.au>
To:	Joe Perches <joe@...ches.com>
Cc:	kaber@...sh.net, davem@...emloft.net,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 18/79] IPVS: Remove useless { } block from
 ip_vs_process_message()

On Tue, Jan 25, 2011 at 12:10:00PM +1000, Simon Horman wrote:
> On Wed, Jan 19, 2011 at 11:40:52AM -0800, Joe Perches wrote:
> > On Wed, 2011-01-19 at 20:14 +0100, kaber@...sh.net wrote:
> > > From: Simon Horman <horms@...ge.net.au>
> > >  net/netfilter/ipvs/ip_vs_sync.c |   24 +++++++++++-------------
> > > diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
> > > @@ -381,20 +381,18 @@ static void ip_vs_process_message(const char *buffer, const size_t buflen)
> > >  			}
> > >  		}
> > >  
> > > -		{
> > > -			if (ip_vs_conn_fill_param_sync(AF_INET, s->protocol,
> > > -					      (union nf_inet_addr *)&s->caddr,
> > > -					      s->cport,
> > > -					      (union nf_inet_addr *)&s->vaddr,
> > > -					      s->vport, &param)) {
> > > -				pr_err("ip_vs_conn_fill_param_sync failed");
> > > -				return;
> > > -			}
> > > -			if (!(flags & IP_VS_CONN_F_TEMPLATE))
> > > -				cp = ip_vs_conn_in_get(&param);
> > > -			else
> > > -				cp = ip_vs_ct_in_get(&param);
> > > +		if (ip_vs_conn_fill_param_sync(AF_INET, s->protocol,
> > > +					       (union nf_inet_addr *)&s->caddr,
> > > +					       s->cport,
> > > +					       (union nf_inet_addr *)&s->vaddr,
> > > +					       s->vport, &param)) {
> > > +			pr_err("ip_vs_conn_fill_param_sync failed");
> > 
> > The original and this pr_err is missing a \n before close quote.
> 
> Thanks Joe, I'll get this fixed once nf-next-2.6 opens up again.

On closer inspection this line has subsequently been removed.
I also checked and the string passed to all calls to pr_erri()
in that file end in "\n".
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html