| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Jan 2011 17:10:00 +0000 From: Ian Campbell <ian.campbell@...rix.com> To: Jeremy Fitzhardinge <jeremy@...p.org> Cc: Ian Campbell <ian.campbell@...rix.com>, Jeremy Fitzhardinge <jeremy@...p.org>, xen-devel@...ts.xensource.com, netdev@...r.kernel.org Subject: [PATCH 2/2] xen: netfront: Drop GSO SKBs which do not have csum_blank. The Linux network stack expects all GSO SKBs to have ip_summed == CHECKSUM_PARTIAL (which implies that the frame contains a partial checksum) and the Xen network ring protocol similarly expects an SKB which has GSO set to also have NETRX_csum_blank (which also implies a partial checksum). Therefore drop such frames on receive otherwise they will trigger the warning in skb_gso_segment. Signed-off-by: Ian Campbell <ian.campbell@...rix.com> Cc: Jeremy Fitzhardinge <jeremy@...p.org> Cc: xen-devel@...ts.xensource.com Cc: netdev@...r.kernel.org --- drivers/net/xen-netfront.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 4dc347b..0ea47da 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -818,6 +818,10 @@ static int validate_incoming_skb(struct sk_buff *skb) if (skb->ip_summed == CHECKSUM_PARTIAL && skb_checksum_setup(skb)) return 0; + /* A GSO SKB must be partial. */ + if (skb->ip_summed != CHECKSUM_PARTIAL && skb_is_gso(skb)) + return 0; + return 1; } -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists