netdev - Re: Realtek r8168C / r8169 driver VLAN TAG stripping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 28 Jan 2011 13:06:24 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Anand Raj Manickam <anandrm@...il.com>
Cc:	netdev@...r.kernel.org, Hayes <hayeswang@...ltek.com>,
	Ivan Vecera <ivecera@...hat.com>
Subject: Re: Realtek r8168C / r8169 driver VLAN TAG stripping

Added Ivan to the Cc:. He has got a 8168c with XID 1c4000c0 and may tell if
hardware VLAN works for him or not.

Anand Raj Manickam <anandrm@...il.com> :
> On Thu, Jan 27, 2011 at 10:20 PM, Francois Romieu <romieu@...zoreil.com> wrote:
> > Anand Raj Manickam <anandrm@...il.com> :
> >> On Thu, Jan 27, 2011 at 8:37 PM, Francois Romieu <romieu@...zoreil.com> wrote:
> >> > Anand Raj Manickam <anandrm@...il.com> :
> > [...]
> >> > - ip addr show
> >>
> >> 3: eth0: <BROADCAST,MULTICAST,UP,10000> mtu 1500 qdisc pfifo_fast qlen 1000
> >>     link/ether 00:17:54:00:f6:62 brd ff:ff:ff:ff:ff:ff
> >>     inet 172.16.1.1/16 brd 172.16.255.255 scope global eth0
> >>     inet6 fe80::217:54ff:fe00:f662/64 scope link
> >>        valid_lft forever preferred_lft forever
> >>
> >> 8: eth0.50@...0: <BROADCAST,MULTICAST,UP,10000> mtu 1500 qdisc noqueue
> >>     link/ether 00:17:54:00:f6:62 brd ff:ff:ff:ff:ff:ff
> >>     inet 172.16.10.10/24 brd 172.16.10.255 scope global eth0.50
> >>     inet6 fe80::217:54ff:fe00:f662/64 scope link
> >>        valid_lft forever preferred_lft forever
> >
> > Could you try again after issuing :
> >
> > ip addr del 172.16.1.1/16 brd 172.16.255.255 dev eth0
> 
> 
> I did try this NO luck ;-(
> 
> > then send the unabbreviated "ip addr show" and "ip route show all" if
> > things do not perform better.
> >
> 
>  ip addr show
> 1: lo: <LOOPBACK,UP,10000> mtu 16436 qdisc noqueue
>     link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
>     inet 127.0.0.1/8 scope host lo
>     inet6 ::1/128 scope host
>        valid_lft forever preferred_lft forever
> 2: sit0: <NOARP> mtu 1480 qdisc noop
>     link/sit 0.0.0.0 brd 0.0.0.0
> 3: eth0: <BROADCAST,MULTICAST,UP,10000> mtu 1500 qdisc pfifo_fast qlen 1000
>     link/ether 00:17:54:00:f6:62 brd ff:ff:ff:ff:ff:ff
>     inet6 fe80::217:54ff:fe00:f662/64 scope link
>        valid_lft forever preferred_lft forever
> 4: eth1: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc pfifo_fast qlen 1000
>     link/ether 00:17:54:00:f6:63 brd ff:ff:ff:ff:ff:ff
> 5: eth2: <BROADCAST,MULTICAST,UP,10000> mtu 1500 qdisc pfifo_fast qlen 1000
>     link/ether 00:30:67:09:2c:b9 brd ff:ff:ff:ff:ff:ff
>     inet 10.1.1.2/24 brd 10.1.1.255 scope global eth2
>     inet6 fe80::230:67ff:fe09:2cb9/64 scope link
>        valid_lft forever preferred_lft forever
> 6: eth3: <BROADCAST,MULTICAST> mtu 1500 qdisc noop qlen 1000
>     link/ether 00:17:54:00:65:6b brd ff:ff:ff:ff:ff:ff
> 7: eth4: <BROADCAST,MULTICAST,UP,10000> mtu 1500 qdisc pfifo_fast qlen 1000
>     link/ether 00:17:54:00:65:6a brd ff:ff:ff:ff:ff:ff
>     inet 192.168.138.155/24 brd 192.168.138.255 scope global eth4
>     inet6 fe80::217:54ff:fe00:656a/64 scope link
>        valid_lft forever preferred_lft forever
> 8: eth0.50@...0: <BROADCAST,MULTICAST,UP,10000> mtu 1500 qdisc noqueue
>     link/ether 00:17:54:00:f6:62 brd ff:ff:ff:ff:ff:ff
>     inet 172.16.10.10/24 brd 172.16.10.255 scope global eth0.50
>     inet6 fe80::217:54ff:fe00:f662/64 scope link
>        valid_lft forever preferred_lft forever

(mostly sequential hardware mac adresses)

Which Arkino product is it ? Quad (+1) port switch / hub ? AK1140 ?

Forget the "ip route show all" for now.

[...]
> >> The same config works on forcedeth
> >
> > What do you call "same config" ?
> 
> The Same setup below works on forcedeth driver

So you can remove any single 8168 adapter from eth[0134], replace it with
an external (non-LOM) forcedeth, keep the three remaining 8168s and it
works correctly ?

If your setup includes a card that contains several 8168 chipsets behind
some kind of bridge, it is not exactly the same setup as a single (LOM ?)
forcedeth network adapter.

[...]
> >
> > I am mildly convinced that your config is simple enough to isolate a
> > driver level vlan problem.
> 
> The reason why i m sure its on the Driver / Chipset is this ..
[printk removed]

Ok. This is an evidence.

Reading my rev1.0 8168c datasheet from may 2007, when there is no tx
offload, no checksumming, the tx descriptor layout should be the same
as the perennial 8169 tx descriptor layout.

Either (1) the VLAN registers and descriptor layout is different for this
chipset or (2) something prevents the register / descriptor write (read ?)
to be completely effective or (3) there is something beyond the 8168 or
(4) there is a 8168 hardware bug.

1 : Hayes may answer. You can give Realtek's own driver a try btw.
2 : Seen before. It could be a software or a (non-8168) hardware one.
    I have no idea if your hardware setup includes a single card with
    four ports or four independent cards with their own 8168 or worse.
3 : See the hardware setup part of (2).
4 : I don't hope so. Hayes may answer as well.

--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html