lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 Jan 2011 01:14:58 -0800 (PST) From: David Miller <davem@...emloft.net> To: ebiederm@...ssion.com Cc: netdev@...r.kernel.org, eric.dumazet@...il.com, kaber@...sh.net Subject: Re: [PATCH] net: Add compat ioctl support for the ipv4 multicast ioctl SIOCGETSGCNT From: ebiederm@...ssion.com (Eric W. Biederman) Date: Sat, 29 Jan 2011 18:15:56 -0800 > > SIOCGETSGCNT is not a unique ioctl value as it it maps tio SIOCPROTOPRIVATE +1, > which unfortunately means the existing infrastructure for compat networking > ioctls is insufficient. A trivial compact ioctl implementation would conflict > with: > > SIOCAX25ADDUID > SIOCAIPXPRISLT > SIOCGETSGCNT_IN6 > SIOCGETSGCNT > SIOCRSSCAUSE > SIOCX25SSUBSCRIP > SIOCX25SDTEFACILITIES > > To make this work I have updated the compat_ioctl decode path to mirror the > the normal ioctl decode path. I have added an ipv4 inet_compat_ioctl function > so that I can have ipv4 specific compat ioctls. I have added a compat_ioctl > function into struct proto so I can break out ioctls by which kind of ip socket > I am using. I have added a compat_raw_ioctl function because SIOCGETSGCNT only > works on raw sockets. I have added a ipmr_compat_ioctl that mirrors the normal > ipmr_ioctl. > > This was necessary because unfortunately the struct layout for the SIOCGETSGCNT > has unsigned longs in it so changes between 32bit and 64bit kernels. > > This change was sufficient to run a 32bit ip multicast routing daemon on a > 64bit kernel. > > Reported-by: Bill Fenner <fenner@...stanetworks.com> > Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com> Thanks a lot for doing this work Eric, applied to net-2.6. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists