[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Wed, 2 Feb 2011 18:40:15 +0100
From: Marcus Meissner <meissner@...e.de>
To: davem@...emloft.net, eric.dumazet@...il.com, ebiederm@...ssion.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
gorcunov@...nvz.org
Subject: af_unix unix_getname: return size for unnamed sockets too small?
Hi,
In net/unix/af_unix.c::unix_getname() there is a small problem:
if (!u->addr) {
sunaddr->sun_family = AF_UNIX;
sunaddr->sun_path[0] = 0; // not copied out
*uaddr_len = sizeof(short);
} else {
struct unix_address *addr = u->addr;
*uaddr_len = addr->len;
memcpy(sunaddr, addr->name, *uaddr_len);
}
The if (!u->addr) case will not copy out the \0 in the sun_path, as
uaddr_len is just the size of sun_family.
(Shown by socat crashing after decoding gethostname return and expected
sun_path to be a valid string (and not seeing the \0)).
Should it perhaps be *uaddr_len = sizeof(short)+sizeof(char)?
Ciao, Marcus
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists