netdev - Re: tlan: Code cleanup: checkpatch.pl is relatively happy now.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 06 Feb 2011 15:24:10 +0200
From:	Sakari Ailus <sakari.ailus@....fi>
To:	Dan Carpenter <error27@...il.com>
CC:	netdev@...r.kernel.org
Subject: Re: tlan: Code cleanup: checkpatch.pl is relatively happy now.

Hi Dan,

Dan Carpenter wrote:
> Commit c659c38b279657 "tlan: Code cleanup: checkpatch.pl is relatively
> happy now." includes the following change without explanation.
>
> -               if ( ( head_list->cStat&  TLAN_CSTAT_READY ) == TLAN_CSTAT_READY ) {
> +               if (head_list->c_stat&  TLAN_CSTAT_READY) {
>
> Was this a bug fix or a bug introduce?

Ouch. Introduce in this case, unfortunately. I *thought* 
TLAN_CSTAT_READY would have been a single bit instead of a bit mask. I 
should have actually checked it, and still put that change into a 
separate patch.

This might not be the one and only place where this kind of shortcut was 
made --- for 80 characters per line compliance. There are very few, 
anyway, in similar places.

I'll recheck the patch and provide a correction, in the coming days likely.

Many thanks for finding this!

-- 
Sakari Ailus
sakari.ailus@....fi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html