lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 06 Feb 2011 11:17:05 -0800 (PST) From: David Miller <davem@...emloft.net> To: geert@...ux-m68k.org Cc: linux-m68k@...r.kernel.org, linux-kernel@...r.kernel.org, cz-bobek-lists-aranym@...ts.bobek.cz, schmitz@...l.biophys.uni-duesseldorf.de, pstehlik@...hics.cz, M.Jurik@...cvut.cz, netdev@...r.kernel.org Subject: Re: [PATCH 4/4] m68k/atari: ARAnyM - Add support for network access From: Geert Uytterhoeven <geert@...ux-m68k.org> Date: Sun, 6 Feb 2011 11:51:09 +0100 > + dev->trans_start = jiffies; Device drivers no longer make this operation, the generic code does it (see net/core/dev.c:dev_hard_start_xmit() and how it invokes txq_trans_update() on ->ndo_start_xmit() success). Therefore, please remove this line. > + pr_debug(DRV_NAME ": send %d bytes\n", len); For consistency with other network drivers, add an appropriate CPP define for "pr_fmt" and use netdev_info(), netdev_debug(), etc. In situations where a netdev pointer is not available (ie. pre-register_netdev()), use "dev_*()" instead. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists