lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Feb 2011 15:44:11 +0100 From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com> To: Sergei Shtylyov <sshtylyov@...sta.com> Cc: linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org, Nicolas Ferre <nicolas.ferre@...el.com>, Paul Chavent <paul.chavent@...c.net> Subject: Re: [PATCH 1/2] atmel/macb: fix device name when SOFT/HARD_IRQ enabled On 16:41 Wed 09 Feb , Sergei Shtylyov wrote: > Hello. > > On 09-02-2011 15:43, Jean-Christophe PLAGNIOL-VILLARD wrote: > > >From: Paul Chavent<paul.chavent@...c.net> > > >When listing processes on a system with SOFT/HARD_IRQ enabled, > >the name of the ethernet device is [irq/eth%d] (instead of [irq/eth0] for example). > > >This patch call the request_irq function after having initialized the name of the device. > > >Signed-off-by: Paul Chavent<paul.chavent@...c.net> > >Signed-off-by: Nicolas Ferre<nicolas.ferre@...el.com> > >Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD<plagnioj@...osoft.com> > [...] > > >diff --git a/drivers/net/macb.c b/drivers/net/macb.c > >index f69e73e..d642e08 100644 > >--- a/drivers/net/macb.c > >+++ b/drivers/net/macb.c > [...] > >@@ -1219,13 +1209,23 @@ static int __init macb_probe(struct platform_device *pdev) > > err = register_netdev(dev); > > if (err) { > > dev_err(&pdev->dev, "Cannot register net device, aborting.\n"); > >- goto err_out_free_irq; > >+ goto err_out_iounmap; > > } > > > >- if (macb_mii_init(bp) != 0) { > >+ dev->irq = platform_get_irq(pdev, 0); > > platform_get_irq() can fail... request_irq will fail too so do we really need to check it? > > >+ err = request_irq(dev->irq, macb_interrupt, IRQF_SAMPLE_RANDOM, > >+ dev->name, dev); Best Regards, J. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists