netdev - RE: [PATCH net-2.6] ixgbe: fix panic due to uninitialied pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 11 Feb 2011 14:47:25 -0800
From:	"Skidmore, Donald C" <donald.c.skidmore@...el.com>
To:	Andy Gospodarek <andy@...yhouse.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"Duyck, Alexander H" <alexander.h.duyck@...el.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Rose, Gregory V" <gregory.v.rose@...el.com>
Subject: RE: [PATCH net-2.6] ixgbe: fix panic due to uninitialied pointer

>-----Original Message-----
>From: Andy Gospodarek [mailto:andy@...yhouse.net]
>Sent: Friday, February 11, 2011 1:46 PM
>To: netdev@...r.kernel.org
>Cc: Skidmore, Donald C; Duyck, Alexander H; Kirsher, Jeffrey T; Rose,
>Gregory V
>Subject: [PATCH net-2.6] ixgbe: fix panic due to uninitialied pointer
>
>Systems containing an 82599EB and running a backported driver from
>upstream were panicing on boot.  It turns out hw->mac.ops.setup_sfp is
>only set for 82599, so one should check to be sure that pointer is set
>before continuing in ixgbe_sfp_config_module_task.  I verified by
>inspection that the upstream driver has the same issue and also added a
>check before the call in ixgbe_sfp_link_config.
>
>Signed-off-by: Andy Gospodarek <andy@...yhouse.net>
>---
> drivers/net/ixgbe/ixgbe_main.c |    6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ixgbe/ixgbe_main.c
>b/drivers/net/ixgbe/ixgbe_main.c
>index fbae703..30f9ccf 100644
>--- a/drivers/net/ixgbe/ixgbe_main.c
>+++ b/drivers/net/ixgbe/ixgbe_main.c
>@@ -3728,7 +3728,8 @@ static void ixgbe_sfp_link_config(struct
>ixgbe_adapter *adapter)
> 			 * We need to try and force an autonegotiation
> 			 * session, then bring up link.
> 			 */
>-			hw->mac.ops.setup_sfp(hw);
>+			if (hw->mac.ops.setup_sfp)
>+				hw->mac.ops.setup_sfp(hw);
> 			if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
> 				schedule_work(&adapter->multispeed_fiber_task);
> 		} else {
>@@ -5968,7 +5969,8 @@ static void ixgbe_sfp_config_module_task(struct
>work_struct *work)
> 		unregister_netdev(adapter->netdev);
> 		return;
> 	}
>-	hw->mac.ops.setup_sfp(hw);
>+	if (hw->mac.ops.setup_sfp)
>+		hw->mac.ops.setup_sfp(hw);
>
> 	if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
> 		/* This will also work for DA Twinax connections */
>--
>1.7.4

Thanks for the patch.  Jeff will pull it into our tree and we will give it some testing but it looks good to me.

-Don Skidmore <donald.c.skidmore@...el.com> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html