netdev - Re: [RFD][PATCH] Add JMEMCMP to Berkeley Packet Filters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 12 Feb 2011 12:47:40 +0000
From:	Ian Molton <ian.molton@...labora.co.uk>
To:	Paul Mackerras <paulus@...ba.org>
CC:	netdev@...r.kernel.org, rdunlap@...otime.net, isdn@...ux-pingi.de,
	arnd@...db.de, davem@...emloft.net, herbert@...dor.apana.org.au,
	ebiederm@...ssion.com
Subject: Re: [RFD][PATCH] Add JMEMCMP to Berkeley Packet Filters

On 12/02/11 02:14, Paul Mackerras wrote:
> On Thu, Feb 10, 2011 at 12:14:46PM +0000, Ian Molton wrote:
>
>> This patch implements an extension for BPF to allow filter programs to use a
>> data section, along with a MEMCMP instruction.
>>
>> There are a few issues noted in the patch itself, which can easily be
>> addressed, and I would like to check wether sk_run_filter is ever expected to
>> be called from a context that cannot sleep (I dont think it is).
>
> The ppp driver (ppp_generic.c) calls sk_run_filter inside a region
> protected by spin_lock_bh, so we can't sleep there.  Having sk_run_filter
> potentially sleep would make it useless for ppp.

Thanks for the review.

I'll fix it not to sleep :)

Do I take it from the lack of people comlpaining that the concept of 
adding this type of instruction itself is not a problem ?

Thanks!

-Ian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html