lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Feb 2011 14:39:15 +0530 From: "Subhasish Ghosh" <subhasish@...tralsolutions.com> To: "Marc Kleine-Budde" <mkl@...gutronix.de> Cc: "Wolfgang Grandegger" <wg@...ndegger.com>, <sachi@...tralsolutions.com>, <davinci-linux-open-source@...ux.davincidsp.com>, "CAN NETWORK DRIVERS" <netdev@...r.kernel.org>, <nsekhar@...com>, "LKML" <linux-kernel@...r.kernel.org>, "CAN NETWORK DRIVERS" <socketcan-core@...ts.berlios.de>, <m-watkins@...com>, <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH v2 09/13] can: pruss CAN driver. Ok, will do NAPI On 02/18/2011 09:15 AM, Subhasish Ghosh wrote: >> On 02/18/2011 08:07 AM, Subhasish Ghosh wrote: >>> -------------------------------------------------- >>> From: "Kurt Van Dijck" <kurt.van.dijck@....be> >> >> ... >>>>> + /* register interrupt handler */ >>>>> + err = request_irq(priv->trx_irq, &omapl_rx_can_intr, IRQF_SHARED, >>>>> + "pru_can_irq", ndev); >>>> you're doing a lot of work _in_ the irq handler. Maybe threaded irq? >>>> >>> SG -Ok, will do >> >> No, please use NAPI instead. > > We are using h/w filters, so the number of interrupts coming into the > processor are not hogging it. > I feel that we may not require an interrupt mitigation. As davem stated the other day, all new drivers should use NAPI. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists