netdev - Re: [PATCH] cxgb{3,4}: streamline Kconfig options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Feb 2011 12:27:09 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	JBeulich@...ell.com
Cc:	divy@...lsio.com, dm@...lsio.com, linux-kbuild@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] cxgb{3,4}: streamline Kconfig options

From: "Jan Beulich" <JBeulich@...ell.com>
Date: Wed, 23 Feb 2011 09:46:10 +0000

>>>> On 22.02.11 at 19:14, David Miller <davem@...emloft.net> wrote:
>> From: "Jan Beulich" <JBeulich@...ell.com>
>> Date: Thu, 17 Feb 2011 13:29:30 +0000
>> 
>>> The CHELSIO_T{3,4}_DEPENDS options are really awkward, and can be
>>> easily dropped if the reverse dependencies of SCSI_CXGB{3,4}_ISCSI on
>>> the former get converted to normal (forward) ones referring to
>>> CHELSIO_T{3,4}.
>>> 
>>> Signed-off-by: Jan Beulich <jbeulich@...ell.com>
>> 
>> I think the goal of these strange rules is not to be complicated
>> on purpose, but rather to cause the iSCSI drivers to appear without
>> the user having to know that he needs to enable the networking
>> driver in order for that to happen.
> 
> While I realize that this might have been the reason, it's completely
> contrary to how everyone else writes dependencies, and hence I
> think these should be removed.

If you knew you were changing the behavior of the config option in
this way, you sure didn't think it was worth mentioning in your commit
message.

I definitely would never expect to have to enable a scsi option to get
some network driver visible to enable in the config, and therefore I
could see the opposite being insanely frustrating too.

You can't ignore these issues and just say "that's not the normal way
so I'm going to change it anyways."


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html