netdev - Re: [PATCH] bonding: fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Feb 2011 14:29:03 -0800
From:	Jay Vosburgh <fubar@...ibm.com>
To:	Stephen Hemminger <shemminger@...tta.com>
cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] bonding: fix sparse warning

Stephen Hemminger <shemminger@...tta.com> wrote:

>Fix use of zero where NULL expected. And wrap long line.
>
>Signed-off-by: Stephen Hemminger <shemminger@...tta.com>

Signed-off-by: Jay Vosburgh <fubar@...ibm.com>


>--- a/drivers/net/bonding/bonding.h	2011-02-23 09:33:39.493248155 -0800
>+++ b/drivers/net/bonding/bonding.h	2011-02-23 09:33:48.825356637 -0800
>@@ -265,7 +265,8 @@ struct bonding {
>  *
>  * Caller must hold bond lock for read
>  */
>-static inline struct slave *bond_get_slave_by_dev(struct bonding *bond, struct net_device *slave_dev)
>+static inline struct slave *bond_get_slave_by_dev(struct bonding *bond,
>+						  struct net_device *slave_dev)
> {
> 	struct slave *slave = NULL;
> 	int i;
>@@ -276,7 +277,7 @@ static inline struct slave *bond_get_sla
> 		}
> 	}
>
>-	return 0;
>+	return NULL;
> }
>
> static inline struct bonding *bond_get_bond_by_slave(struct slave *slave)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html